-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mature test suites #9
Comments
Here's the NIST suite + added autocorrelation function: https://github.com/montanaflynn/stats/tree/nist_test_suite |
I am not sure about what did you mean here, it is about to rewrite NIST test suite in GO? and then replace all tests? |
@LuizClaudioSantos I think the idea was that the more tests the better, so instead of replacing tests it would be adding more tests from mature projects, such as NIST and others that we could find. Actually I already added some of NIST test suite: https://github.com/montanaflynn/stats/blob/master/nist_test.go |
What do you think about using https://pkg.go.dev/github.com/stretchr/testify. |
@tzzed I don't see the need for that, we're not using http or mocks so testing is pretty straight forward and easy with the standard library testing. |
I agree but it is just about to have a lazyness way with |
Having a dependency used only for development isn't something I would like to add. I think a little more boilerplate but using standard library is a good trade-off to avoid dependency pains for downstream users. |
It makes sense! |
Even though I've spent a lot of time writing tests for stats I think it could benefit from incorporating other more mature test suites from other statistics tools as well. For instance here's a NIST test suite used by Gnu gsl which could be ported to Go and added as a test for stats.
I'm sure there are other test suites as well, let me know if you have suggestions or want to help with this!
The text was updated successfully, but these errors were encountered: