Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing coverage - cov-fail-under setting #2097

Closed
1 task
briangrossman opened this issue Jan 29, 2021 · 3 comments
Closed
1 task

Improve testing coverage - cov-fail-under setting #2097

briangrossman opened this issue Jan 29, 2021 · 3 comments
Assignees

Comments

@briangrossman
Copy link
Contributor

As an xPRO engineer, I want to ensure I have proper test coverage on all the code. As referenced in #2076, we should add the flag --cov-fail-under=NN for our baseline coverage percentage, increasing it as we work our way to 100% coverage. Start at 85%.

Designs and Mockups

Peter discovered this doc, which should be helpful.

Acceptance Criteria:

  • Configure the option --cov-fail-under=NN
@HamzaIbnFarooq
Copy link
Contributor

HamzaIbnFarooq commented Feb 1, 2021

@briangrossman is adding more tests under the scope of this PR? as if we use the mentioned code coverage threshold 85 it will start failing all the new PRs because the current code coverage is 82.74.

For now, I have added 82.70 as the threshold value, so new PRs will not be blocked until they decrease the Performace to 82.70.

@rhysyngsun
Copy link
Collaborator

@HamzaIbnFarooq increasing test coverage is scoped in #2076

@briangrossman
Copy link
Contributor Author

@HamzaIbnFarooq : Good point about the threshold. Setting it to 82.70 is perfect. Thanks for adding the list to #2076, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants