implicit casting workaround #744
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Nov 15, 2024
|
Please fill out the PR template for each PR. |
mtfriesen
reviewed
Nov 15, 2024
published/external/xdp/status.h
Outdated
| @@ -25,11 +25,14 @@ typedef NTSTATUS XDP_STATUS; | |||
|
|
|||
| typedef HRESULT XDP_STATUS; | |||
|
|
|||
| #define SUCCESS_HRESULT_FROM_WIN32(x) \ | |||
There was a problem hiding this comment.
We can't do this, because other code does HRESULT_FROM_WIN32(GetLastError()) and would produce inconsistent results. What are you trying to achieve here?
There was a problem hiding this comment.
I just copied from MsQuic. trying to resolve implicit cast. I'm not sure how to resolve other than this
There was a problem hiding this comment.
I think your original solution was fine, other than a comment was needed.
This reverts commit 244f0e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #741.
Implicit cast
Testing
CI
Documentation
N/A
Installation
N/A