Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: orf.gping version 1.19.0 #212330

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New package: orf.gping version 1.19.0 #212330

wants to merge 2 commits into from

Conversation

ChristopherHaklar
Copy link

@ChristopherHaklar ChristopherHaklar commented Jan 15, 2025 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

PR relating to Issue #212278
Manifest created by using winget-create

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ChristopherHaklar
Copy link
Author

@microsoft-github-policy-service agree

This was referenced Jan 15, 2025
Closed
Open
@Dragon1573
Copy link
Contributor

Hello @ChristopherHaklar, 👋🏼

Tip

Link this pull request to the issue with "closing keyword" is preferred. This can help remining other contributors & moderators that the issue is currently work in progress.

- [x] Is there a linked issue? Resolve #212278

@ChristopherHaklar ChristopherHaklar marked this pull request as ready for review January 15, 2025 17:30
@wingetbot
Copy link
Collaborator

/AzurePipelines run

2 similar comments
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 16, 2025
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 17, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 17, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\orf.gping__DefaultSource\gping.exe returned exit code: -1073741515
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\gping.exe returned exit code: -1073741515

Automated error analysis suggests -1073741515 may mean STATUS_DLL_NOT_FOUND - possibly due to a dependency on Microsoft.VCRedist.2015+.x64 (or .x86).

(Automated response - build 942.)

stephengillie
stephengillie requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

manifests/o/orf/gping/1.19.0/orf.gping.installer.yaml Show resolved Hide resolved
@stephengillie
Copy link
Collaborator

Verify with dependency:
image

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Jan 17, 2025
@ChristopherHaklar @stephengillie
Add Dependencies
b9bd556 
Co-authored-by: Stephen Gillie <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Executable-Error labels Jan 18, 2025
@wingetbot wingetbot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 18, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 18, 2025
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

ChristopherHaklar,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: gping
4 participants
@ChristopherHaklar @wingetbot @Dragon1573 @stephengillie