Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make telemetry info table a little bit narrower and aligned #233961

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make telemetry info table a little bit narrower and aligned #233961

wants to merge 2 commits into from
+5 −5

Conversation

mattmaniak
Copy link

@mattmaniak mattmaniak commented Nov 15, 2024 •
edited
Loading

The current table in defaultSettings.json was formatted using variables from the telemetryService.ts which are longer than the variables content itself.

Fixes: #233959

Before:

	// |       | Crash Reports | Error Telemetry | Usage Data |
	// |:------|:---------------------:|:---------------:|:--------------:|
	// | all   |            ✓          |        ✓        |        ✓       |
	// | error |            ✓          |        ✓        |        -       |
	// | crash |            ✓          |        -        |        -       |
	// | off   |            -          |        -        |        -       |

After:

	// |       | Crash Reports | Error Telemetry | Usage Data |
	// |:------|:-------------:|:---------------:|:----------:|
	// | all   |       ✓       |        ✓        |     ✓     |
	// | error |       ✓       |        ✓        |     -      |
	// | crash |       ✓       |        -        |     -      |
	// | off   |       -       |        -        |     -      |

@mattmaniak mattmaniak changed the title Make telemetry info table a little bit narrower but aligned Make telemetry info table a little bit narrower and aligned Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lramos15 lramos15 Awaiting requested review from lramos15

At least 1 approving review is required to merge this pull request.

Assignees

@joyceerhl joyceerhl

Labels
triage-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry info table is not aligned in defaultSettings.json
2 participants
@mattmaniak @joyceerhl