Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link bundled LLVM tools against shared VC runtime to reduce size of VSIX #13151

Open
Colengms opened this issue Jan 14, 2025 · 0 comments
Open
Assignees
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service

Comments

@Colengms
Copy link
Contributor

To address another issue, I've had to link libiconv.dll, and binaries that reference it, against the shared runtime. (libiconv returns results in errno, so it's necessary for the caller to link against the same runtime to access the same errno variable). We already distribute the shared runtime in our 'bin' directory.

It would be possible to link our bundled LLVM tools (clang-tidy, clang-format) to the shared runtime as well. Currently, they are linked statically against the runtime. We'd have to move them into the same 'bin' directory. This could slightly reduce the size of the VSIX.

@Colengms Colengms self-assigned this Jan 14, 2025
@Colengms Colengms added the internal Used to opt-out an issue from having GitHub actions applied to it label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service
Projects
Status: No status
Development

No branches or pull requests

1 participant