Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfocusedAppearance ignores backgroundImage set to null and continued to display image #12643

Open
Tracked by #9995
doverton12 opened this issue Mar 8, 2022 · 1 comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone

Comments

@doverton12
Copy link

Windows Terminal version

1.13.10395.0

Windows build number

10.0.22567.1

Other Software

No response

Steps to reproduce

It is possible to set in the UI, and via the settings XML, for there to be no background image when a terminal windows is unfocused using the example below:
"unfocusedAppearance":
{
"backgroundImage": null
}

Expected Behavior

The expected behaviour is that the background image will disappear when set to null or change image to a new image if a value is set

Actual Behavior

Actual behaviour is that the background image continues to be displayed if set to null, although a new image is displayed if a correct file location is set.

@doverton12 doverton12 added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 8, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 8, 2022
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Mar 9, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 9, 2022
@zadjii-msft zadjii-msft added this to the 22H2 milestone Mar 9, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 16, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
@scottpickett
Copy link

I'm also having this issue on an instance of Windows Terminal Version: 1.21.3231.0 on Windows 11.

null does not replace the current backgroundImage value when unfocusedAppearance is triggered.

Workaround Solution:

Add, or integrate, the following to settings.json:

"unfocusedAppearance": 
  {
    "backgroundImageOpacity": 0
  }

This worked for my implementation and allows my desired background and foreground values to display correctly when unfocusedAppearance is active.

Working example snippet:

            "unfocusedAppearance": 
            {
                "background": "#7F5501",
                "foreground": "#808000",
                "opacity": 100,
                "backgroundImage": null,
                "backgroundImageOpacity": 0
            }

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants