Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Option to Choose SQL PowerShell Module When Restoring From BacPac #3763

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

MattTraxinger
Copy link
Contributor

Fixes #3762

This is a change to how Restore-BcDatabaseFromArtifacts chooses which PowerShell module to use. I have added an optional parameter, SqlModuleToUse, with two possible values, sqlps and sqlserver, and a default value of sqlps to preserve existing functionality.

I've also added the same parameter to New-BcContainer.

@MattTraxinger MattTraxinger requested a review from a team as a code owner November 14, 2024 21:47
@MattTraxinger
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="ArcherPoint"]

@MattTraxinger
Copy link
Contributor Author

@microsoft-github-policy-service agree company="ArcherPoint"

Copy link
Contributor

@freddydk freddydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments
Add a setting in Bc.HelperFunctions.ps1 (like useApproximateVersion) and use that as default for the two functions.
plus add a line to release notes.

Bacpac/Restore-BcDatabaseFromArtifacts.ps1 Outdated Show resolved Hide resolved
Bacpac/Restore-BcDatabaseFromArtifacts.ps1 Show resolved Hide resolved
ContainerHandling/New-NavContainer.ps1 Outdated Show resolved Hide resolved
@freddydk
Copy link
Contributor

sorry if my review was too early:-)

@MattTraxinger
Copy link
Contributor Author

All good. I appreciate the thorough review.

@freddydk freddydk merged commit 08e2f35 into microsoft:main Nov 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to provide parameter for which SQL PowerShell module to use
2 participants