-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give Option to Choose SQL PowerShell Module When Restoring From BacPac #3763
Conversation
@microsoft-github-policy-service agree [company="ArcherPoint"] |
@microsoft-github-policy-service agree company="ArcherPoint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
Add a setting in Bc.HelperFunctions.ps1 (like useApproximateVersion) and use that as default for the two functions.
plus add a line to release notes.
sorry if my review was too early:-) |
All good. I appreciate the thorough review. |
Fixes #3762
This is a change to how Restore-BcDatabaseFromArtifacts chooses which PowerShell module to use. I have added an optional parameter, SqlModuleToUse, with two possible values, sqlps and sqlserver, and a default value of sqlps to preserve existing functionality.
I've also added the same parameter to New-BcContainer.