Add support for WDK 26100.0 #4015
Open
+18
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
mikeagun
previously approved these changes
Nov 15, 2024
|
What problem is this fixing? The PR adds another path after Include\10.0.22621.0\km which means if any file exists in 22621 it will be used instead. Any file that is new in 26100 will use 26100, resulting in a mismatch of headers, which may break compilation. |
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
force-pushed
the
fix_build
branch
from
f0cdaf4
to
cac4e5b
Compare
The issue is that GitHub us rolling out 26100 which breaks eBPF for Windows builds |
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
force-pushed
the
fix_build
branch
from
77b4c93
to
73ce735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4016
Description
This pull request includes an update to the
Directory.Build.propsfile to add a new Windows SDK directory to the additional include directories.Directory.Build.props: Added$(WindowsSdkDir)Include0.0.26100.0\kmto theAdditionalIncludeDirectoriesto include the new Windows SDK directory.Testing
CI/CD
Documentation
No.
Installation
No.