Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic events for eBPF extension entry points and exit points #3829

Open
mtfriesen opened this issue Sep 12, 2024 · 0 comments · May be fixed by #3830
Open

Add diagnostic events for eBPF extension entry points and exit points #3829

mtfriesen opened this issue Sep 12, 2024 · 0 comments · May be fixed by #3830
Assignees
Labels
enhancement New feature or request triaged Discussed in a triage meeting
Milestone

Comments

@mtfriesen
Copy link
Collaborator

Describe the feature you'd like supported

eBPF supports an arbitrary number of extensions, and at the moment there are no diagnostic events within eBPF to trace each time an extension calls batch_invoke(), batch_start(), etc. This would be useful to solve at the eBPF runtime layer, rather than each extension devising its own logging scheme.

Proposed solution

Add enter/exit traces for each eBPF entrypoint from an extension. Manifested ETW events have lower CPU and memory cost than the existing TraceLogging infrastructure within eBPF (but higher development costs) and since this is a hot and performance-sensitive code path, it may be worth setting up a manifest for hot code path diagnostics.

The diagnostics should include common ETW fields (timestamp, CPU, thread, etc.) along with unique identifiers for the eBPF program and extension.

Additional context

Helpers functions implemented within extensions should perform their own logging. It may also be useful to add logs for eBPF internal subroutines or eBPF helper functions.

@mtfriesen mtfriesen added the enhancement New feature or request label Sep 12, 2024
@Alan-Jowett Alan-Jowett added the triaged Discussed in a triage meeting label Sep 16, 2024
@Alan-Jowett Alan-Jowett added this to the 2410 milestone Sep 16, 2024
@mtfriesen mtfriesen linked a pull request Sep 16, 2024 that will close this issue
@shankarseal shankarseal modified the milestones: 2410, 2411 Sep 30, 2024
@shankarseal shankarseal modified the milestones: 2411, 2501 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Discussed in a triage meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants