Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static version numbers #8

Open
FirePing32 opened this issue Jan 31, 2024 · 6 comments
Open

Fix static version numbers #8

FirePing32 opened this issue Jan 31, 2024 · 6 comments

Comments

@FirePing32
Copy link
Contributor

The current brew formula uses a fixed version number for Python and the Core repo. Also, the hash needs to be dynamic depending on the core repo version.

@viferga
Copy link
Member

viferga commented Feb 21, 2024

@FirePing32 I do not understand what is this issue about, can you explain it?

@FirePing32
Copy link
Contributor Author

@viferga Currently, we have to manually add commit hash every time a new version is released on metacall/core. Also, the Python version is static, which needs to be dynamic according to the user's machine to avoid build errors (like missing header files). The release version of the core repo is also statically defined in the formula.

@shaggyyy2002
Copy link

@FirePing32 If i am getting it right, cant we just create a main trigger at the meta call core repo and when the tests.yml is passed it will trigger the build in all other repos as we want??

@FirePing32
Copy link
Contributor Author

@shaggyyy2002 That is the plan as of now.

@shaggyyy2002
Copy link

@FirePing32 I have a GSoC proposal, mind if you could review it? This issue can be solved under the same
Core CI with Distributable's project

@FirePing32
Copy link
Contributor Author

@shaggyyy2002 I am planning to contribute as a contributor myself, but if you want to share it, you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants