Bug: Loan graph shows Red when balance goes down, even though the % decrease vs previous month is green (as expected)

[evanrich]

Describe the bug
When you have a loan, say a home loan,the graph shows red when the balance decreases, despite the dollar and percentage staying green:

To Reproduce
Steps to reproduce the behavior:

1. add a loan, with balance, interest rate, and term
2. update the balance
3. the graph shows green but the tooltip shows red

Expected behavior
all numbers are green since a decreasing loan balance is a good thing

What version of Maybe are you using?
0.2.0-alpha.2

What operating system and browser are you using?
Windows 11, Chrome (latest version)

Screenshots / Recordings

[zachgoll]

This function needs to consider the classification (asset / liability) of the account:

maybe/app/javascript/controllers/time_series_chart_controller.js

Lines 405 to 411 in 3bc9da4

	_tooltipTrendColor(datum) {
	return {
	up: tailwindColors.success,
	down: tailwindColors.error,
	flat: tailwindColors.gray[500],
	}[datum.trend.direction];
	}

Our server-side code already does this, but the Stimulus controller does not.

Ideally we'd only have to handle this in one spot (server-side), but it may be more pragmatic to just duplicate the logic in this case. I haven't really dug in too much yet to tell.

[evanrich]

Thanks for the reply, I wouldn't consider this a p0 or anything since it's only the tooltip thats affected, everything else reflects green for "improvement" so its a minor issue.