Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore support and testing of Go 1.22.0 #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dnwe
Copy link

@dnwe dnwe commented Jan 17, 2025

  • relax go directive to 1.22.0 to match the N-1 and N support statement and permit run/build with go1.22.0 and newer
  • update the test fixtures go.mod similarly to make them representative
  • use the toolchain directive to recommend the latest 1.23.x (Go treats this as advisory)
  • fix the CI build so that oldstable and stable are actually being tested by telling setup-go to ignore the toolchain directive
  • use go build tags to add a stub for types.Alias on go1.22 and (somewhat ironically!) use a simple type Alias to the builtin on go1.23 and newer

Fixes #312

- relax go directive to 1.22.0 to match the N-1 and N support statement
  and permit run/build with go1.22.0 and newer
- update the test fixtures go.mod similarly to make them representative
- use the toolchain directive to _recommend_ the latest 1.23.x (Go
  treats this as advisory)
- fix the CI build so that oldstable and stable are actually being
  tested by telling setup-go to ignore the toolchain directive
- use go build tags to add a stub for types.Alias on go1.22 and
  (somewhat ironically!) use a simple type Alias to the builtin on
  go1.23 and newer

Fixes maxbrunsfeld#312

Signed-off-by: Dominic Evans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility Go release 1.22 toolchain go1.23.1
1 participant