Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imagick PHP extension back for PHP 8.x #363

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dossy
Copy link

@dossy dossy commented Jan 9, 2024

Description

PHP 8.x Docker images are missing the imagick PHP extension. This PR brings them back.

Bonus: This PR also adds WebP support to PHP 7.4 and PHP 8.x's GD extension.

Fixed Issues (if relevant)

  1. magento/magento-cloud-docker#357: Incompatibility with Magento >= 2.4.0 (Imagick missing)

Fixes #357.

Manual testing scenarios

  1. php bin/ece-docker image:generate:php
  2. Add the context images to your docker-compose.override.yml's services like this:
services:
  fpm:
    build:
      context: ./vendor/magento/magento-cloud-docker/images/php/8.1-fpm
      dockerfile: Dockerfile
  fpm_xdebug:
    build:
      context: ./vendor/magento/magento-cloud-docker/images/php/8.1-fpm
      dockerfile: Dockerfile
  generic:
    build:
      context: ./vendor/magento/magento-cloud-docker/images/php/8.1-cli
      dockerfile: Dockerfile
  build:
    build:
      context: ./vendor/magento/magento-cloud-docker/images/php/8.1-cli
      dockerfile: Dockerfile
  deploy:
    build:
      context: ./vendor/magento/magento-cloud-docker/images/php/8.1-cli
      dockerfile: Dockerfile
  1. docker compose build fpm
  2. docker compose run --rm fpm php -i | awk '/imagick module/,/^$/'
  3. Look for imagick module => enabled in the output from step 4.
  4. docker compose run --rm fpm php -i | awk '/GD Support/,/^$/'
  5. Look for WebP Support => enabled in the output from step 6.

Release notes

  • Add imagick PHP extension back to PHP 8.x Docker images.
  • Add WebP support to PHP 7.4 and PHP 8.x's GD extension in Docker images.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful release notes and documentation
  • All commits are accompanied by meaningful commit messages

@dossy
Copy link
Author

dossy commented Jan 9, 2024

Closing and re-opening after signing CLA.

@MaximGns
Copy link

will this ever be merged? lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

Incompatibility with Magento >= 2.4.0 (Imagick missing)
2 participants