Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjoint 4pi convolution and interpolation #16

Open
mreineck opened this issue Mar 5, 2020 · 4 comments
Open

adjoint 4pi convolution and interpolation #16

mreineck opened this issue Mar 5, 2020 · 4 comments
Assignees

Comments

@mreineck
Copy link
Collaborator

mreineck commented Mar 5, 2020

Implement code which performs the adjoint operation of what's done in #12. While not necessary for time stream generation, it is an important ingredient in deconvolution map mapmaking.

@mreineck mreineck self-assigned this Mar 5, 2020
@mreineck
Copy link
Collaborator Author

mreineck commented Mar 5, 2020

The basic code is there, but adjointness tests fail. I'm debugging this.

@mreineck
Copy link
Collaborator Author

Adjointness is fixed. The adjoint convolution code is not yet properly parallelized, but that is an easier task than ensuring correctness.

If someone would like to validate the code, feel free!

@ziotom78
Copy link
Member

Hi @mreineck , I am not an expert of the mathematics behind convolutions, but I downloaded your code and compiled it: everything worked as expected, and pytest ran 8 tests successfully.

@mreineck
Copy link
Collaborator Author

Thanks!

For the next steps, I'll simply provide the triple of convolved values for T, G and C separately. Even if this is not exactly what's required, I'm confident that the necessary quantities can be computed from this triple; and in the longer term I'll of course adjust the code if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants