Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change attach by debug CLI command in user namespace example #48676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seifrajhi
Copy link
Member

Description

Fixes error reported in #48675

Closes: #48675

image

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2024
Copy link

netlify bot commented Nov 10, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 21b6e34
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6731b10ac7c2c8000858ae36
😎 Deploy Preview https://deploy-preview-48676--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seifrajhi I see the bot has added do-not-merge/invalid-commit-message as the commit message has #<issue number> (Refer Blocked Keywords Guide). Would you be able to edit the commit message in order to move this PR forward?

For reference, below is the current commit message that triggered the issue.

Minor fix: change attach by debug CLI command, fixes #48675

@seifrajhi seifrajhi changed the title Minor fix: change attach by debug CLI command, fixes #48675 Change attach by debug CLI command in user namespace example Nov 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 11, 2024
@seifrajhi
Copy link
Member Author

Thank you @dipesh-rawat , it should be good now

Comment on lines -75 to 79
1. Attach to the container and run `readlink /proc/self/ns/user`:
1. Add a debugging container and attach to it and run `readlink /proc/self/ns/user`:

```shell
kubectl attach -it userns bash
kubectl debug userns -it --image=busybox
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the right change to make? I think attaching to or exec-ing into the existing container was the intent here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as I mentioned in the issue either exec or debug are fine, I just chose debug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through on a local cluster and the debug command works as intended.

@salaxander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea4c46781bda123cd64aea0dc1db98b0c3bacc41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with user namespace example in documentation: Pod creation fails
5 participants