-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change attach by debug CLI command in user namespace example #48676
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seifrajhi I see the bot has added do-not-merge/invalid-commit-message
as the commit message has #<issue number>
(Refer Blocked Keywords Guide). Would you be able to edit the commit message in order to move this PR forward?
For reference, below is the current commit message that triggered the issue.
Minor fix: change attach by debug CLI command, fixes #48675
Thank you @dipesh-rawat , it should be good now |
1. Attach to the container and run `readlink /proc/self/ns/user`: | ||
1. Add a debugging container and attach to it and run `readlink /proc/self/ns/user`: | ||
|
||
```shell | ||
kubectl attach -it userns bash | ||
kubectl debug userns -it --image=busybox | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this the right change to make? I think attaching to or exec-ing into the existing container was the intent here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as I mentioned in the issue either exec
or debug
are fine, I just chose debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through on a local cluster and the debug command works as intended.
/lgtm |
LGTM label has been added. Git tree hash: ea4c46781bda123cd64aea0dc1db98b0c3bacc41
|
Description
Fixes error reported in #48675
Closes: #48675