Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make clean #12228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix make clean #12228

wants to merge 1 commit into from

Conversation

mneverov
Copy link
Member

Avoid elevating permissions to clean cache directories by using host user in docker and -modcacherw in go build command.

Permissions were used previously but were modified in #8400 to be used for mac users only and subsequently removed in #9124.

The issue let me think that no one runs make clean, so another option is just to remove it.

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #12227

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@mneverov
Avoid elevating permissions to clean cache directories by using host …
7a8315f 
…user in docker and "-modcacherw" in go build command.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mneverov
Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 7a8315f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67190369e898680008e5627a

@longwuyuan
Copy link
Contributor

I think local dev/test requires make clean

@Gacko
Copy link
Member

Gacko commented Oct 23, 2024

If this is about Go cache files, the issue is not about the user, but about the file permissions. And there is a reason for them to be read-only I'd like to keep that.

@mneverov
Copy link
Member Author

If this is about Go cache files, the issue is not about the user, but about the file permissions.

@Gacko can you post the ls -lart output from the repo root folder and ls -lart rootfs?

And there is a reason for them to be read-only I'd like to keep that.

Can you clarify what the reason is?

As I mentioned, I cloned the repo, ran make build; make clean and the latter failed. If it works as intended, why not removing the target at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco Awaiting requested review from puerco

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make clean doesn't work
4 participants
@mneverov @k8s-ci-robot @longwuyuan @Gacko