Be able to use relative redirects (in Location header)

[chriss-de]

What do you want to happen?
If I do a redirects to /location I want the HTTP Location header to show Location: /location
Currently you get Location: http://host/location
That's because nginx has a config setting absolute_redirect which is on by default.

Is there currently another issue associated with this?
not AFAIK

Does it require a particular kubernetes version?
no

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[longwuyuan]

Thanks @chriss-de

Is this about configuring redirects using the annotations (permanent/temporal) ?

[longwuyuan]

oh I see you are adding new annotations

[simhnna]

The background to the feature request is that we're doing TLS termination before nginx. So nginx only sees http traffic. Using absolute redirects always returns http.
HSTS should take care of the problem, but to be extra safe we'd like to not return http at all. If the redirects are relative we wouldn't have the issue

[strongjz]

Would it just be adding a config option to disable to absolute_redirect to off?

The config map is defined here https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/

I think it would be a good first issue for someone to try to add it https://github.com/kubernetes/ingress-nginx/blob/main/internal/ingress/controller/config/config.go

For the core maintainers, we are focused on security, tech debt, and gatewayAPI work; we would not prioritize this.

/good-first-issue

[k8s-ci-robot]

@strongjz:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Would it just be adding a config option to disable to absolute_redirect to off?

The config map is defined here https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/

I think it would be a good first issue for someone to try to add it https://github.com/kubernetes/ingress-nginx/blob/main/internal/ingress/controller/config/config.go

For the core maintainers, we are focused on security, tech debt, and gatewayAPI work; we would not prioritize this.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[strongjz]

This PR https://github.com/kubernetes/ingress-nginx/pull/12161/files ?

[strongjz]

#12161