Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enable-access-log annotation to set 'access_log on' #12078

Open
vanny96 opened this issue Oct 2, 2024 · 2 comments · May be fixed by #12081
Open

Allow enable-access-log annotation to set 'access_log on' #12078

vanny96 opened this issue Oct 2, 2024 · 2 comments · May be fixed by #12081
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@vanny96
Copy link

vanny96 commented Oct 2, 2024

As a kubernetes cluster administrator, I'd like to set the default access_log for the ingresses to off (achieving this by using disable-access-log on the ConfigMap).
This works great, but as of right now there is no way to turn on access_log on demand for specific environments. I would have assumed that using nginx.ingress.kubernetes.io/enable-access-log: "true" would allow to set the access_log back to on, but by looking at the nginx.tmpl it looks like this annotation only takes effect when the annotation is set to false.

Would it be possible to change enable-access-log such as:

  • true: sets access_log on
  • false: sets access_log off
  • unset: sets nothing, keeps parent behaviour
@vanny96 vanny96 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 2, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vanny96 vanny96 linked a pull request Oct 2, 2024 that will close this issue
Open
10 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
[SIG Network] Ingress NGINX
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allows allows-access-logs to set 'access_log on' vanny96/ingress-nginx
2 participants
@k8s-ci-robot @vanny96