Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VPA test for namespace flags #7699

Open
adrianmoisey opened this issue Jan 15, 2025 · 1 comment
Open

Add VPA test for namespace flags #7699

adrianmoisey opened this issue Jan 15, 2025 · 1 comment
Labels
area/vertical-pod-autoscaler kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adrianmoisey
Copy link
Member

Over in #7698 it was discovered that parts of code that depended on vpa-object-namespace and ignored-vpa-object-namespaces were set incorrectly.

However, no tests caught this. We should write a test so that if an error like this is made in the future, the test will fail.

/area vertical-pod-autoscaler
/triage accepted
@adrianmoisey adrianmoisey added the kind/bug Categorizes issue or PR as related to a bug. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 15, 2025
@adrianmoisey adrianmoisey mentioned this issue Jan 15, 2025
Merged
@omerap12
Copy link
Member

I think we should add tests for all flags, not just namespace flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/vertical-pod-autoscaler kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrianmoisey @k8s-ci-robot @omerap12