Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart - Allow custom extra arguments #7422

Open
nicolas-laduguie opened this issue Oct 22, 2024 · 3 comments
Open

Helm chart - Allow custom extra arguments #7422

nicolas-laduguie opened this issue Oct 22, 2024 · 3 comments
Labels
area/cluster-autoscaler area/helm-charts kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nicolas-laduguie
Copy link

Which component are you using?:
Helm chart

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
At the moment, the helm chart provides ability to give extraArgs in yaml key=value format, or eventually key for arguments not requiring any value (see https://github.com/kubernetes/autoscaler/blob/1603c19e62dc46a9bb1d176624e1964d974b3ef1/charts/cluster-autoscaler/templates/deployment.yaml#L128C45-L128C54).
For some other needs, it would be beneficial to let the user provide any value as an extra argument.
For instance providing a env variable like $ENV_VAR as an extra argument would help making arguments more dynamic, loaded from configmap or secrets for instance.

Describe the solution you'd like.:

Since the extraArgs value is already templated and computed in a specific way, would be easier to create a new customArgs value that would be given as is to the command.

@nicolas-laduguie nicolas-laduguie added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2024
@adrianmoisey
Copy link
Member

/area helm-charts

@adrianmoisey
Copy link
Member

/area cluster-autoscaler

@omerap12
Copy link
Member

PR submitted here: #7423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/helm-charts kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants