Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert resources and components to be backed by a reusable generator #4402

Open
Tracked by #5198
KnVerey opened this issue Jan 19, 2022 · 11 comments · May be fixed by #5773
Open
Tracked by #5198

Convert resources and components to be backed by a reusable generator #4402

KnVerey opened this issue Jan 19, 2022 · 11 comments · May be fixed by #5773
Assignees
@koba1t
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Jan 19, 2022

This is required for the Composition KEP, so that Compositions can use these key features.

Kustomize Plugin Composition API #2299
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 19, 2022
@KnVerey KnVerey added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 19, 2022
This was referenced Jan 19, 2022
Closed
Closed
@KnVerey KnVerey mentioned this issue Apr 13, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2022
@KnVerey
Copy link
Contributor Author

KnVerey commented Apr 20, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2022
@KnVerey KnVerey mentioned this issue Jun 8, 2022
Closed
@natasha41575
Copy link
Contributor

For anyone interested in working on this, there is a brief description of how our generators/transformers are implemented in this comment. #4671 (comment)

You can take the ConfigMapGenerator as an example. We want a plugin like that called ResourceGenerator, except instead of generating a ConfigMap, it should generate resources by reading from the resources field of the kustomization file.

Running make should automatically update our builtin plugins here and after that there will be some more work to hook up the resources field to invoke the new ResourceGenerator.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2022
@KnVerey
Copy link
Contributor Author

KnVerey commented Oct 11, 2022

/kind cleanup
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 11, 2022
@KnVerey KnVerey mentioned this issue Mar 15, 2023
Closed
@natasha41575 natasha41575 mentioned this issue Jun 9, 2023
Open
4 tasks
@swastik959 swastik959 mentioned this issue Jun 14, 2023
Closed
@swastik959
Copy link

@KnVerey hi I have tried to work on the issue and create a pull request can you please take a look

@natasha41575
Copy link
Contributor

Hi @swastik959, apologies, but I think this issue is complicated and your PR does not completely resolve the issue. I think this issue requires a bit more context and @koba1t is going to work on it, as he has been working on kustomize for a longer time and has the context to understand the full requirements.

Please feel free to take a look at issues labeled "good first issue" or "help wanted".

/assign @koba1t

@natasha41575 natasha41575 mentioned this issue Jun 19, 2023
Closed
renovate bot referenced this issue in scottames/dots Jun 19, 2023
@renovate
chore(deps): update aqua (#58)
68ec677 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[kubernetes-sigs/kustomize](https://togithub.com/kubernetes-sigs/kustomize)
| minor | `v5.0.3` -> `v5.1.0` |
| [zellij-org/zellij](https://togithub.com/zellij-org/zellij) | patch |
`v0.37.0` -> `v0.37.1` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/kustomize</summary>

###
[`v5.1.0`](https://togithub.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.1.0)

[Compare
Source](https://togithub.com/kubernetes-sigs/kustomize/compare/kustomize/v5.0.3...kustomize/v5.1.0)

##### Highlights

Components are now applied after generators:
[https://github.com/kubernetes-sigs/kustomize/pull/5170](https://togithub.com/kubernetes-sigs/kustomize/pull/5170)

We made this change cautiously as we want to avoid user friction when
updating kustomize; however we felt that it is a bug that resources from
`resources` and resources from generators are treated differently. Given
that components is currently an alpha feature, we felt that now was the
time to adjust if ever.

We are currently working on on
[https://github.com/kubernetes-sigs/kustomize/issues/4402](https://togithub.com/kubernetes-sigs/kustomize/issues/4402),
which will make the ordering of `resources`, `components`, and
`generators` customizable in the kustomization file. Please use that
issue for tracking if you are blocked from upgrading kustomize for this
reason, and we hope to have it available soon.

See
[https://github.com/kubernetes-sigs/kustomize/issues/5141](https://togithub.com/kubernetes-sigs/kustomize/issues/5141)
for more detailed discussion.

##### Bug fixes:


[#&#8203;5030](https://togithub.com/kubernetes-sigs/kustomize/issues/5030):
`kustomize edit` will return an error if there is no matching path

[#&#8203;5170](https://togithub.com/kubernetes-sigs/kustomize/issues/5170):
components are now applied after generators

##### Dependency updates


[#&#8203;5186](https://togithub.com/kubernetes-sigs/kustomize/issues/5186):
Update gnostic dependency with gnostic-models

[#&#8203;5187](https://togithub.com/kubernetes-sigs/kustomize/issues/5187):
Bump to go 1.20

[#&#8203;5212](https://togithub.com/kubernetes-sigs/kustomize/issues/5212):
pin to kyaml v0.14.3

[#&#8203;5213](https://togithub.com/kubernetes-sigs/kustomize/issues/5213):
pin to cmd/config v0.11.3

[#&#8203;5214](https://togithub.com/kubernetes-sigs/kustomize/issues/5214):
pin to api 0.14.0

</details>

<details>
<summary>zellij-org/zellij</summary>

###
[`v0.37.1`](https://togithub.com/zellij-org/zellij/releases/tag/v0.37.1)

[Compare
Source](https://togithub.com/zellij-org/zellij/compare/v0.37.0...v0.37.1)

##### RELEASE IN PROGRESS

Thank you for your patience!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@koba1t koba1t mentioned this issue Jun 28, 2023
Draft
@natasha41575 natasha41575 moved this from Todo to In Progress in Kustomize KRM Functions & Kyaml Aug 18, 2023
@annasong20 annasong20 mentioned this issue Aug 30, 2023
Closed
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 13, 2024
@koba1t
Copy link
Member

koba1t commented Jun 16, 2024

/triage accepte

@k8s-ci-robot
Copy link
Contributor

@koba1t: The label(s) triage/accepte cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepte

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@koba1t
Copy link
Member

koba1t commented Jun 16, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 16, 2024
@LittleChimera LittleChimera linked a pull request Sep 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koba1t koba1t

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Kustomize KRM Functions & Kyaml
Status: In Progress
Milestone
No milestone
6 participants
@KnVerey @natasha41575 @k8s-ci-robot @koba1t @swastik959 @k8s-triage-robot