Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event strings are should be enums #1897

Open
flavono123 opened this issue Dec 31, 2024 · 5 comments · May be fixed by #1915
Open

event strings are should be enums #1897

flavono123 opened this issue Dec 31, 2024 · 5 comments · May be fixed by #1915
Assignees
@flavono123
Labels
good-first-issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@flavono123
Copy link

Description

What problem are you trying to solve?

to get all reason from karpenter controllers', for now, have to parse the codes since they are as string.
these should be constants i guess (and i could if some naming conventions are)

How important is this feature to you?

not urgent but required for monitoring events by controllers

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@flavono123 flavono123 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 31, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 31, 2024
@flavono123 flavono123 changed the title event strings are should be enum event strings are should be enums Dec 31, 2024
@jonathan-innis jonathan-innis added the good-first-issue Good for newcomers label Jan 13, 2025
@jonathan-innis
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2025
@jonathan-innis
Copy link
Member

Makes sense to me -- we should probably just gather the reasons in a shared package like in the apis directory so that they have a very small dependency chain and they can be easily accessed everywhere without pulling in too many other dependencies

@jonathan-innis
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 13, 2025
@flavono123
Copy link
Author

ok.
can i try a PR for this? i'm asking if i can, do i have to label somewhat to this issue?

@flavono123
Copy link
Author

have learned from other issues

/assign

@flavono123 flavono123 linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flavono123 flavono123

Labels
good-first-issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move event reasons to the package and as constants flavono123/karpenter
3 participants
@k8s-ci-robot @flavono123 @jonathan-innis