Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support shared IP assignment for MetalLB CRDs #579

Open
TimJones opened this issue Oct 9, 2024 · 1 comment · May be fixed by #580
Open

Support shared IP assignment for MetalLB CRDs #579

TimJones opened this issue Oct 9, 2024 · 1 comment · May be fixed by #580
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@TimJones
Copy link
Contributor

TimJones commented Oct 9, 2024 •
edited
Loading

We need to use MetalLB CRDs as our cluster has too many Services defined to fit into the old ConfigMap structure. These Services all share the same IP, but CPEM currently doesn't support this as indicated by this TODO

cloud-provider-equinix-metal/metal/loadbalancers/metallb/cr.go

Lines 155 to 156 in 0de9ce3

// TODO (ocobleseqx)
// - Metallb allows ip address sharing for services, so we need to find a way to share a pool

My initial idea would be to add another label to the IPAddressPool created by CPEM to indicate that the original Service has the official MetalLB shared IP annotation, and check when adding a new IPAddressPool one already exists with the matching key, in which case we add the service label and key to the existing IPAddressPool.
@displague displague assigned displague and unassigned displague Oct 10, 2024
@displague displague added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 10, 2024
@abant07
Copy link

abant07 commented Oct 15, 2024 •
edited
Loading

Hey @TimJones

I am new to contributing to Kubernetes, and I read through the community documentation on how to get started. It led to me to the good first issues, and this issue seemed interesting to me. I was wondering how I can get started on this, I would like to work on it.

Do I just assign myself? Are there some environments I need to spin up on my local computer to contribute?

Also, I saw in the documentation there is a Contributor License Agreement to submit PRs, where do I fill that out?

Thanks!
Amogh

@TimJones TimJones linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for metallb shared addresses TimJones/cloud-provider-equinix-metal
3 participants
@TimJones @displague @abant07