Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support feature flags through KnativeServing CRD in the Operator #1838

Open
kromanow94 opened this issue Jul 15, 2024 · 3 comments
Open

Support feature flags through KnativeServing CRD in the Operator #1838

kromanow94 opened this issue Jul 15, 2024 · 3 comments
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@kromanow94
Copy link

Problem
It would be nice if the knative feature flags could be configurable through the KnativeServing CRD.

https://knative.dev/docs/serving/configuration/feature-flags/

Persona:
System Operator

Exit Criteria
Feature flags can be configured by the Operator for knative serving through the KnativeServing CRD.

@houshengbo
Copy link
Contributor

@kromanow94 Do you mean to configure the config-features ConfigMap?
The operator is able to configure any ConfigMap available with knative serving and eventing: https://knative.dev/docs/install/operator/configuring-with-operator/#configuring-knative-by-using-the-operator

@kromanow94
Copy link
Author

Maybe the config-features config map is supported by the operator through code but not in the CRD? I wasn't able to find the features: section in the CRDs:

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants