Replies: 1 comment 2 replies
-
I agree with adding the rule, this will prevent us from committing code that has focused tests. Just as a side-note, projects should also have code coverage gates, no matter how high or low the current percentages are, just have gates slightly below current metrics. The build should fail if those gates do not pass. That way, even if you do not have this rule, the tests will almost certainly fail if you have focused some individual test (suite) and the build will not pass. @thabalija or @danipavic can one of you create a PR? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We should prevent commiting fdescribe/fit.
Jasmine plugin: eslint-plugin-jasmine
Beta Was this translation helpful? Give feedback.
All reactions