Current date and time intents

[synesthesiam]

Hi @home-assistant/language-leaders 👋

There are two new basic intents that will be available in the next version of HA:

• HassGetCurrentDate
  • Responds with the current date
  • Receives a Python date object in slots.date
• HassGetCurrentTime
  • Responds with the current time
  • Receives a Python time object in slots.time

It's important that you do not use strftime in the response! This will format dates/times according to the locale of the machine HA is running on, not the locale of the intent.

For the English date response, I just hard-coded the month names and day ordinals (1st, 2nd, etc.). Dealing with locales in standard Python is more trouble than it's worth for these intents 😄

[tetele]

Why don't we expose a proper localization method as a Jinja filter? Or at least pass the date/time as an already formatted string based on the request's language.

This approach feels half-baked and is one more of those things upon which we will stumble later, IMHO. 🤷‍♂️

[TheFes]

@andrejs2 what's the full YAML you used now

For both the test and the response

[andrejs2]

@andrejs2 what's the full YAML you used now

For both the test and the response

EDIT: @TheFes please disregard my post. Culprit lies in missing quotes, like this and it passes the test:
response: "1:02"

@TheFes , thanks...here you go :)

responses:

language: sl
responses:
  intents:
    HassGetCurrentTime:
      default: >
        {% set minute_str = '{0:02d}'.format(slots.time.minute) %}
        {{ slots.time.hour }}:{{ minute_str }}

test:

language: sl
tests:
  - sentences:
      - "koliko je ura"
      - "trenutna ura"
      - "trenuten čas"
    intent:
      name: HassGetCurrentTime
    response: 1:02

output of test is:

Running tests for file homeassistant_HassGetCurrentTime.yaml

Validation failed

Language: sl
[ERROR] tests/sl/homeassistant_HassGetCurrentTime.yaml: invalid format: expected str for dictionary value @ data['tests'][0]['response']. Got 62
[ERROR] homeassistant_HassGetCurrentTime.yaml has no tests


 *  The terminal process "/bin/bash '-c', 'script/test_file tests/sl/homeassistant_HassGetCurrentTime.yaml'" terminated with exit code: 1. 
 *  Terminal will be reused by tasks, press any key to close it. 

[TheFes]

Add quotes around the response in the test

response: "1:02"

[andrejs2]

Thanks @TheFes it works with quotes. Have plenty of other test without quotes but this one needs :)

[tetele]

@synesthesiam i mean no offense, i'm just saying that something as common as month names should not have to be translated again.

There are already a few things which lack modularity and are hard to maintain, such as measurements with units and i feel like this is another thing which we might need to copy-paste or manually edit in several places. The issue is not that we have to do it, it's that well intended PRs from contributors will miss these places and then we either reject PRs or have inconsistencies. Maybe it's just my own experience due to the fact that English has the most PRs from inexperienced contributors who don't want (or need) to understand how everything works before fixing their own little issue.

[TheFes]

Should we include the weekday as well?
Like Friday 11th of July?
We can use slots.data.weekday() for that

[andrejs2]

I assume the slots.data.weekday() returns integer?
Sorry for the dumb question...

[TheFes]

@andrejs2 yes, with 0 being Monday
So you can put the weekday names in a list

{% set weekday = [ 'monday', 'tuesday',  'wednesday', 'thursday', 'friday', 'saturday' , 'sunday' ] %}
{{ weekday[slots.date.weekday()] }}

[andrejs2]

@TheFes thank you! It works now. Should we add this?

[jlpouffier]

Done for French #2306 (comment)

[davefx]

Done for Spanish #2311

[swonge]

Done for Zh-Hk #2312<#2312>

…

________________________________ From: David Marín ***@***.***> Sent: Friday, July 12, 2024 5:43:09 AM To: home-assistant/intents ***@***.***> Cc: Steve Wong ***@***.***>; Team mention ***@***.***> Subject: Re: [home-assistant/intents] Current date and time intents (Discussion #2305) Done for Spanish #2311<#2311> — Reply to this email directly, view it on GitHub<#2305 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGG7JKYQXT6TQ4VFSH5AZLZL7FN3AVCNFSM6AAAAABKXD6I2SVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMBTGE2TCMI>. You are receiving this because you are on a team that was mentioned.Message ID: ***@***.***>

[andreasbrett]

Done for German #2314

[abmantis]

Done for PT: #2374