Add Docker repositories to Terraform

[nyarly]

Dependency

• The Terraform Migration Epic #20

Overview

Incubator projects use AWS Docker repositories with a machine-generated URL - a good sign that a resource should be added to Terraform.

Action Items

• Determine how the Incubator docker registry was configured
• Add a Registry resource to shared_resources
• Apply that configuration and use terraform state import to bring the Registry under IaC management
• Refer to the registry in repository names (e.g. people-depot-backend-dev:latest) instead of hardcoding a machine-generated URL.

Resources/Instructions

https://developer.hashicorp.com/terraform/language/state/import
https://registry.terraform.io/providers/-/aws/latest/docs/resources/ecr_repository

[JasonEb]

https://github.com/hackforla/incubator/blob/ba9bb47dc6f28cc2b9b27274e1e3b026a8abb3d8/terraform-incubator/people-depot/dev/main.tf#L29C24-L29C24

[JasonEb]

Looks like the ECR url is going to be static - I don't think that makes it as dynamic or machine generated.

Both the terraform documentation and the AWS ECR documentation point out that the url is of the form https://<:aws_account_id>.dkr.ecr.<:region-name>.amazonaws.com

Our account_id and region should rarely change. Nonetheless think we can wrap that url into a shared resource then reference that

[robinglov]

What if any responsibility will ops have for this issue?

[ale210]

somewhat unclear here, but jason has a good point in that they are not precisely random or machine generated. could possibly be added as output to a project but tbd

[ExperimentsInHonesty]

@ale210 Please do not add things to the icebox in they have no defined dependency. Otherwise, we have to keep re-reading the issue over and over again to determine when to take it out of the icebox. Here are examples

• issue with a defined dependency that is an issue: Deploy standard labels to all repos ops#63
• issue with a defined dependency that is a clear narrative: Slack Alternatives: Pumble ops#48