Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncTransactionManager.CommitTimestampFuture violates Future.get contract #3414

Open
SanjayVas opened this issue Oct 15, 2024 · 0 comments
Open

AsyncTransactionManager.CommitTimestampFuture violates Future.get contract #3414

SanjayVas opened this issue Oct 15, 2024 · 0 comments
Assignees
@sakthivelmanii
Labels
api: spanner Issues related to the googleapis/java-spanner API.

Comments

@SanjayVas
Copy link

CommitTimestampFuture violates the Future contract by overriding get() to throw any caught exception other than ExecutionException. Namely, it unwraps any AbortedException and throws that directly.

This breaks any downstream code that operates on that CommitTimestampFuture via the Future interface. For example, transforming it to a Guava ListenableFuture and then calling the kotlinx.coroutines.guava.await extension function on it.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakthivelmanii sakthivelmanii

Labels
api: spanner Issues related to the googleapis/java-spanner API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SanjayVas @rahul2393 @sakthivelmanii