Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching #159

Open
eddiemonge opened this issue Jan 13, 2023 · 1 comment
Open

Caching #159

eddiemonge opened this issue Jan 13, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@eddiemonge
Copy link

Have you considered caching the binary so it runs faster? This is one of the longest running steps in my actions

@jonabc
Copy link
Contributor

jonabc commented Jan 13, 2023

The latest licensed major release (4.x) no longer supports distributing licensed as a binary and licensed will be released as gem-only for the indefinite future.

The action generally only runs long when querying the GitHub API for available distributed binaries. The action gets rate limited by the GitHub API which causes the slowdown. These API calls won't happen when pulling the gem, which should lead to the action running much more quickly in the future.

As I mentioned in response to your other comment I'm pretty busy with work and life and don't have too much time to devote to optimizations in the action so I'm not planning to add caching at this time. I'll add a help wanted label in case anyone else feels like taking a look, but in the meantime I'd suggest installing licensed in your action workflow as a gem to speed up your action runs.

@jonabc jonabc added the help wanted Extra attention is needed label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants