Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/async-preventdefault should not flag calls before the first await #599

Open
silverwind opened this issue Jan 13, 2025 · 0 comments
Open

Comments

@silverwind
Copy link

silverwind commented Jan 13, 2025

preventDefault() works fine before the first await in an async function, so this code works as expected, but if currently flagged:

document.querySelector('a').addEventListener('click', e => {
  e.preventDefault();
  await fetch('/');
});

It's only after the first await, where preventDefault stops working. I suggest the rule to only flag preventDefault() after the first await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant