-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the intended workflow for the Dependabot PRs? #25
Comments
I had the same question. I'm currently looking how can I currently automatically close those combined prs |
The individual Dependabot PRs automatically always move to a |
Ah thanks @gedwards1 to clarify sorry. This does indeed work for Dependabot PRs. Do you know the schedule - how quickly this takes effect? It doesn't work for non-Dependabot tooling though of course (in our case we are hoping to merge across a variety of tools). |
Oh I misread your initial Comment @nicl, my bad. You're saying that it would be nice if this Action closed the PRs that it added to the Combined PR. I could see the benefit of that. I didn't create this Action but my understanding of the "intended workflow" is that you just merge the Combined PR and that indirectly causes the open Individual PRs to change to a
For me this wouldn't be worth the effort to add since how I use it allows me to ignore the original PRs. But if someone added the feature it I'd consider using it.
If you're referring to how long it takes for the individual PRs to change to a
I'm surprised to hear that. My understanding/assumption is that this Action should behave identically for non-Dependabot PRs as long as you change the |
Hi, just testing this action - thanks for it!
Something that is unclear to me is the intended workflow for Dependabot PRs once the combined PR is opened/merged. Is the idea that the individual Dependabot PRs should be manually closed? I was expecting this action to close individual PRs once they've been added to the combined PR, but this doesn't seem to be the case, and I can't see anything in the code to suggest it should do this either.
If not, should we add this? It seems less helpful to do the work of raising a combined PR if manual action on the individual PRs is still required.
The text was updated successfully, but these errors were encountered: