Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle different build systems #11

Open
Tracked by #4
ZoomTen opened this issue Jul 21, 2023 · 0 comments
Open
Tracked by #4

Handle different build systems #11

ZoomTen opened this issue Jul 21, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
v0.2

Comments

@ZoomTen
Copy link
Collaborator

ZoomTen commented Jul 21, 2023

Right now it just runs make (not even make install!) a possible future version of RGBDS may change this.

Ideas floated about in the chat include:

  • Detect Cargo.toml or Makefile, and run build commands accordingly. If Cargo build command is hardcoded into rgbenv, it may introduce incompatibilities.
  • Always use Make. Some amount of anachronism is to be felt when having a Makefile that runs Cargo... but I think could work.
  • Detect Makefile, and if not present try running build.sh. Gets rid of hard dependency on Make.
@ZoomTen ZoomTen added this to the v0.2 milestone Jul 21, 2023
@ZoomTen ZoomTen mentioned this issue Jul 21, 2023
Open
5 tasks
@ZoomTen ZoomTen added the enhancement New feature or request label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@ZoomTen