Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File->"Playable" should be true by default/if the value is absent #241

Open
avivace opened this issue Jun 6, 2024 · 3 comments
Open

File->"Playable" should be true by default/if the value is absent #241

avivace opened this issue Jun 6, 2024 · 3 comments
Labels

Comments

@avivace
Copy link
Member

avivace commented Jun 6, 2024

No description provided.

@avivace avivace added the schema label Jun 6, 2024
@dag7dev
Copy link
Contributor

dag7dev commented Oct 17, 2024

can we assume every entry in the database has at least one gb/gbc/gba playable file?

@avivace
Copy link
Member Author

avivace commented Oct 17, 2024

can we assume every entry in the database has at least one gb/gbc/gba playable file?

nope not really, there are some metadata-only entries. I'm not sure what this issue was about lol

@dag7dev
Copy link
Contributor

dag7dev commented Oct 17, 2024

I'm not sure what this issue was about lol

I remember an issue like that some time ago too.

Anyway, this leads in some complications:

  1. we cannot assume that every entry in the database has at least one playable file
  2. we cannot assume that the first file in the "files" array is the most up-to-date version (we may have contributors that has put most recent entry file at the end and not beginning)

Therefore, i'd edit this issue with "add a playable field to AT LEAST one playable file, if not present".

The work should be something like:

  1. scan every json
  2. if "playable: true" is present and the file is a gb/gbc/gba whatever playable file, good
  3. if not, then add it to the first occurrence

We still have the second problem (not most up-to-date guaranteed), but at least we have the guarantee that each file is listed and playable.

I don't remember if this check already occurs at a certain point in the pipeline...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants