Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete logic around "smPush" #91

Open
moT01 opened this issue Oct 24, 2023 · 0 comments
Open

Delete logic around "smPush" #91

moT01 opened this issue Oct 24, 2023 · 0 comments
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@moT01
Copy link
Member

moT01 commented Oct 24, 2023 •
edited
Loading

Hey @Sboonny, was this something that was just missed on that PR? or is something not working as expected?

It is something missed that should have been accounted for in that PR. if this is merged with the switching to smOffset, please delete the logic around smPush as it is no longer necessary

Originally posted by @Sboonny in freeCodeCamp/freeCodeCamp#52008 (comment)

I believe he is referring to the use of smPush in the component library. A quick search shows a few results. I believe those can all just be deleted.
@moT01 moT01 added status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Oct 24, 2023
@Sembauke Sembauke transferred this issue from freeCodeCamp/freeCodeCamp Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moT01