Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded podcasts episode order by recently downloaded #1086

Open
Nirajn2311 opened this issue Aug 10, 2023 · 6 comments
Open

Downloaded podcasts episode order by recently downloaded #1086

Nirajn2311 opened this issue Aug 10, 2023 · 6 comments
Labels
help wanted Open for all. You do not need permission to work on these. type: bug Issues that need priority attention. Things which are obviously broken and are reported as such.

Comments

@Nirajn2311
Copy link
Member

Describe the bug
The downloaded episodes of any podcast currently shows the episodes in oldest to newest order.

Expected behavior
The episodes should be ordered to show the recently downloaded episode first for each podcast.

@Nirajn2311 Nirajn2311 added type: bug Issues that need priority attention. Things which are obviously broken and are reported as such. first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Aug 10, 2023
@SharmaDhruv2511
Copy link

SharmaDhruv2511 commented Sep 14, 2023

I want to work on this issue. Can you please assign me the issue? and adding to it can you please mark out the file where i can get the downloading of podcast code?

@himanshu608
Copy link

Isn't the current behavior more appropriate?
As the downloaded section of each podcast represents similar to as how we explore it.
Which gives user same experience in downloaded section as in exploring podcast.
When we explore the podcast, each video is listed in descending order, and when we download it, the same behavior displays in downloaded section.??

@himanshu608
Copy link

the episode model does not store downloaded date as mentioned in mode :
Episode_model

Solution 1:
Adding download date to the model and sort the results by downloaded date in getEpisodes query whenEver we are in DownloadView state,Episode List View model.

Solution 2: We can just reverse the list when we fetch the episodes from downloaded database.

@himanshu608
Copy link

As in our DB : PRIMARY KEY (id, podcastId)
We are using episode_ID and Podcast_ID for our primary key,
So reversing the list does not solve our problem, I think.
@Nirajn2311 Is there something I am missing here?

@Sembauke
Copy link
Member

@himanshu608

We can just reverse the list when we fetch the episodes from downloaded database.

Lets go with this.

@Nirajn2311
Copy link
Member Author

My bad, I hadn't thoroughly investigated this behavior in other podcast applications. We shouldn't be touching the episode order even when they've been downloaded. @himanshu608 was right about that behavior.

But the order in which podcasts are displayed can be varies. Some show them in the same order while others display podcasts in descending order of their last downloaded episode. I personally prefer not changing the order, what do the rest of you think?

@Sembauke Sembauke added help wanted Open for all. You do not need permission to work on these. and removed first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. type: bug Issues that need priority attention. Things which are obviously broken and are reported as such.
Projects
None yet
Development

No branches or pull requests

4 participants