Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart [min, max] does not optimise for values #100

Open
siddharthkp opened this issue Dec 15, 2017 · 3 comments · May be fixed by #120
Open

Chart [min, max] does not optimise for values #100

siddharthkp opened this issue Dec 15, 2017 · 3 comments · May be fixed by #120
Labels
enhancement hacktoberfest

Comments

@siddharthkp
Copy link

siddharthkp commented Dec 15, 2017 •
edited
Loading

Expected Behaviour

Chart min and max values should optimise for data values. This was also initially reported in #57 and fixed after that.

Actual Behaviour

There is a bunch of space above and below the line (see image)

Steps to Reproduce:

Data values are from 13.45 to 14.52
Code is here: http://jsbin.com/wodujuk/1/edit?js,output

screen shot 2017-12-15 at 12 18 15 pm

Frappé Charts version: https://unpkg.com/[email protected]/dist/frappe-charts.min.iife.js
@siddharthkp
Copy link
Author

@pratu16x7 👋

@kronthto
Copy link

I am displaying a chart for the User count in an application in the last few weeks. Values ranging from 29.996 to 30.432.

Using version 0.0.8 I get this: usergrowth_frappe_white_space

It would be nice if there was less blank space and maybe the Y-axis min/max being closer to the values (like in my example 29.000 to 31.000).

kronthto added a commit to kronthto/frappe-charts that referenced this issue Feb 13, 2018
@kronthto
Calculate exponent for intervals based on range between values
f997f70 
Aims to resolve frappe#100
@kronthto kronthto linked a pull request Feb 13, 2018 that will close this issue
Open
@kronthto
Copy link

I achieved positive results by changing the way the exponent used for interval generation is determined: I tried calculating it based on the range between the min/max-values instead of the absolute values.
See PR #120

@kepano kepano mentioned this issue Apr 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calculate exponent for intervals based on range between values kronthto/frappe-charts
3 participants
@siddharthkp @kronthto @scmmishra