edit-form-validation #970
Open
edit-form-validation #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #970 +/- ##
===============================================
+ Coverage 64.9% 64.92% +0.02%
===============================================
Files 109 109
Lines 2701 2703 +2
Branches 302 303 +1
===============================================
+ Hits 1753 1755 +2
Misses 865 865
Partials 83 83
Continue to review full report at Codecov.
|
|
hey please check this out, @Achint08 @sk9331657 |
|
I think this PR solves the validation part (which is good) but doesn't solve the whole issue as the formspree is returning 403. otherwise LGTM . |
|
@Aaryan-kapur Pls squash your commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
please check and suggest improvements, if any!
screenshots
http://pr-970-fossasia-loklaksearch.surge.sh
Closes #936
Thank You,
Aaryan-Kapur
[email protected]
(+91)-7507442555