Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown "behavior" prop description duplicates "multiple" #99

Open
benlind opened this issue Aug 16, 2023 · 1 comment
Open

Dropdown "behavior" prop description duplicates "multiple" #99

benlind opened this issue Aug 16, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@benlind
Copy link
Contributor

benlind commented Aug 16, 2023

On the dropdown page, in the props & attributes section, the description of the "behavior" prop seems to be incorrect:

When set to overscroll, the dropdown will allow the user to select multiple options.

That just duplicates the "multiple" prop:

When set to true, the dropdown will allow the user to select multiple options.

It should likely instead say something like "overscroll causes the options to scroll above the input."

Also, unrelatedly, it seems weird that "overscroll" is the only possible value for the "behavior" prop, even though there are many other props under the "behavioral" section on that page.

@sashamilenkovic sashamilenkovic self-assigned this Aug 16, 2023
@sashamilenkovic sashamilenkovic added the documentation Improvements or additions to documentation label Aug 16, 2023
@sashamilenkovic
Copy link
Contributor

@benlind Whoops! Thanks for letting me know. I'll get a fix up for that.

As for:

Also, unrelatedly, it seems weird that "overscroll" is the only possible value for the "behavior" prop, even though there are many other props under the "behavioral" section on that page.

I completely agree. You should just be able to set overscroll and maybe we deprecate behavior as a prop entirely. At some point we'll get a fix out for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants