Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing search variable in AssociateAction.recordSelectOptionsQuery #14686

Open
hsul4n opened this issue Nov 1, 2024 · 2 comments
Open

Missing search variable in AssociateAction.recordSelectOptionsQuery #14686

hsul4n opened this issue Nov 1, 2024 · 2 comments
Labels

Comments

@hsul4n
Copy link

hsul4n commented Nov 1, 2024

Package

filament/filament

Package Version

v3.2

Laravel Version

v11.9.0

Livewire Version

v3.5.4

PHP Version

PHP 8.3.0

Problem description

I noticed that recordSelectOptionsQuery function not having search variable which is important to customize query for example using custom scope query for searching

$relationshipQuery = $this->evaluate($this->modifyRecordSelectOptionsQueryUsing, [

Expected behavior

recordSelectOptionsQuery function must have search variable

Steps to reproduce

1- Add Filament\Tables\Actions\AssociateAction::make() action into table header actions.
2- Call $action->recordSelectOptionsQuery(fn($query, $search) => $query->customScope($search)).

Reproduction repository (issue will be closed if this is not valid)

https://github.com/filamentphp/demo

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
Copy link

github-actions bot commented Nov 1, 2024

Hey @hsul4n! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Thank you for providing reproduction steps! Reopening the issue now.

@github-actions github-actions bot reopened this Nov 1, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Roadmap Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant