Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spin pluginify for CI? #80

Open
vdice opened this issue Sep 12, 2023 · 3 comments
Open

Use spin pluginify for CI? #80

vdice opened this issue Sep 12, 2023 · 3 comments

Comments

@vdice
Copy link
Member

vdice commented Sep 12, 2023

Would spin pluginify be a good fit to replace the current script used to create new plugin release manifests? It would be great to use the same tool both in local dev mode and in CI.

We'd need pluginify to:

  • Create a manifest with all supported os/arch combos for a given release version and download url (not sure if this can already be accomplished by the tool today)
  • Support overriding the following values in spin-pluginify.toml when creating a manifest as described above: version and homepage (to support canary releases for the former and support publishing the plugin from forks for the latter)

Thoughts @itowlson @karthik2804 ?

@karthik2804
Copy link
Collaborator

That would be great to have a common tool do it across all the plugins. I do believe that Pluginify has the ability to unify multiple manifests into a "super" manifest (for lack of a better word).

@itowlson
Copy link
Contributor

It does, but the resultant workflow isn't elegant, e.g. https://github.com/fermyon/spin-trigger-sqs/blob/main/.github/workflows/build.yml

But I'm sure we could make it better with wiser eyes than mine on it!

@rajatjindal
Copy link
Contributor

FWIW, on the side I am working on https://github.com/rajatjindal/spin-plugin-release-bot. This will enable publishing new releases as PR to spin-plugin repo, which we can then review/merge (also candidate for automation and on my radar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants