Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing name for application when deploying #8

Open
mikkelhegn opened this issue May 26, 2023 · 3 comments
Open

Support providing name for application when deploying #8

mikkelhegn opened this issue May 26, 2023 · 3 comments

Comments

@mikkelhegn
Copy link
Member

The cloud api supports defining a name for an application, when creating it. Today this is inferred from the spin.toml file on deployment.

It would be great to be able to define this as part of deployment. E.g. spin cloud deploy --name my-app

@lann
Copy link
Collaborator

lann commented May 26, 2023

Are you saying you want to allow deploying with a different name by specifying --name every time you deploy?

@mikkelhegn
Copy link
Member Author

I think you're hinting at the identifier being id and not name. The behavior today to create a new app, would be to change the name in spin.toml, and I think it's a bit weird.

If the "same" spin.toml is deployed twice with two different names, I believe a new app should be created.

We might need id as well as an option, but I think a name need to be unique across a user's account today.

I don't think we need to be able to change the name of an application as part of deployment. Although I see there's an api for that.

@lann
Copy link
Collaborator

lann commented May 26, 2023

The behavior today to create a new app, would be to change the name in spin.toml, and I think it's a bit weird.

Yeah I think this is the underlying issue. There is nothing else in the manifest you have to change as an operational detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants