-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Rename agent_config to runtime_config #330
Comments
Should we consider using configuration library like https://www.boost.org/doc/libs/1_85_0/libs/config/doc/html/index.html ? Since it will be more convenient to manage and parse configuration from multiple sources |
It seems what you mentioned is not a config library, but how to config the boost library for different compiler/usecases |
Any recommendations for libraries? |
https://github.com/hyperrealm/libconfig maybe? It seems our configurations are simple and don't need such libraries for management |
Sorry, my fault, too sleepy now. Try libconfig |
Yes, this is what I would like to reocmmend. Though the configuration structure of bpftime is simple now, but it has a big chance to get more complicated in the future. |
well...what kinds of new configuration would bpftime have in the future? I'm not quite sure about that. I would suggest that we focus on the small number of configurations we have now, and don't need a library to handle that |
Ok, let's focus on configurations now and don't adopt a config library |
Is your feature request related to a problem? Please describe.
As time envolve, The agent config in https://github.com/eunomia-bpf/bpftime/blob/master/runtime/include/bpftime_config.hpp is no longer only for the agent. It should contain all the runtime config.
And also, the two config in
bpftime/runtime/syscall-server/syscall_context.cpp
Line 35 in 87a8901
bpftime/runtime/src/bpftime_config.cpp
Line 41 in 87a8901
Describe the solution you'd like
The text was updated successfully, but these errors were encountered: