Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prow postsubmit jobs #18885

Open
2 tasks
ivanvc opened this issue Nov 12, 2024 · 6 comments
Open
2 tasks

Enable prow postsubmit jobs #18885

ivanvc opened this issue Nov 12, 2024 · 6 comments
Assignees
Labels
area/testing area/tooling good first issue priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented Nov 12, 2024

What would you like to be added?

After the prow migration, we deleted the CI checks against the main branch. We should restore some of the jobs as postsubmit jobs.

Refer to our current presubmit job configurations and postubmit's

  • post-etcd-verify (based on pull-etcd-verify)
  • post-etcd-govulncheck (based on pull-etcd-govulncheck)

Why is this needed?

To improve the code quality, and ensure the main branch doesn't have static analysis issues and vulnerabilities.

@ivanvc
Copy link
Member Author

ivanvc commented Nov 12, 2024

@jmhbnz, this is the issue we spoke about yesterday. I did a pass on the current presubmit jobs, and we should only enable the two listed before. Please let me know, or update the list with the ones you think should be added (or removed).

After that, we can set it as a good first issue.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 13, 2024

/retitle Enable prow postsubmit jobs

@k8s-ci-robot k8s-ci-robot changed the title Enable prow prosubmit jobs Enable prow postsubmit jobs Nov 13, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Nov 13, 2024

Agree the two listed jobs are a great start let's focus on those for now.

@jmhbnz jmhbnz added area/testing area/tooling priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted good first issue labels Nov 13, 2024
@samuelbartels20
Copy link

@ivanvc Please assign me to this ticket, I will get it done

@ahrtr
Copy link
Member

ahrtr commented Nov 14, 2024

/assign @samuelbartels20

Thank you!

@samuelbartels20
Copy link

@ivanvc @ahrtr @jmhbnz Please i have raised a PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing area/tooling good first issue priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Development

No branches or pull requests

4 participants