Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle multiple, similar, reference to the same file #59

Open
abirtley opened this issue Aug 15, 2017 · 1 comment
Open

Doesn't handle multiple, similar, reference to the same file #59

abirtley opened this issue Aug 15, 2017 · 1 comment

Comments

@abirtley
Copy link

abirtley commented Aug 15, 2017

See original issue here: ember-cli/broccoli-asset-rev#116

Given the input:

<img src="assets/images/picture.png"/>
<img src="/assets/images/picture.png"/>

And a fingerprint of https://mycdn.com/

The output is:

<img src="https://mycdn.com/assets/images/picture.png"/>
<img src="/https://mycdn.com/assets/images/picture.png"/>

(Note the incorrect slash at the start of the second URL.)

This can be avoided by using the exact same URLs everywhere in your source code. It would be nice, however, if the rewrite engine handled this automatically (eg a sort to process the longer replacements first?)

@tschoartschi
Copy link

This seems to be very similar to the issue I reported. See: #63

I think it's a problem with the regex but I'm afraid to change the regex since I can not estimate if and how a change of this regex could break existing apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants