Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Publish60Hosted_Works not using the live runtime dependencies #44886

Open
ViktorHofer opened this issue Nov 15, 2024 · 2 comments · May be fixed by #44888
Open

Investigate Publish60Hosted_Works not using the live runtime dependencies #44886

ViktorHofer opened this issue Nov 15, 2024 · 2 comments · May be fixed by #44888
Assignees
@akoeplinger
Labels
untriaged Request triage from a team member

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 15, 2024 •
edited by akoeplinger
Loading

Disabling the test meanwhile.
We found that it is referencing an older version of Microsoft.NET.Sdk.WebAssembly.Pack
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Nov 15, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger akoeplinger self-assigned this Nov 15, 2024
akoeplinger added a commit that referenced this issue Nov 15, 2024
@akoeplinger
Fix updating KnownWebAssemblySdkPack when creating test layout
b2c8363 
We missed adding KnownWebAssemblySdkPack into OverrideAndCreateBundledNETCoreAppPackageVersion so it was pointing to an older version in the BundledVersion.props in the test layout.

Fix that and add some checks so we don't miss this again the next time we add a Known*Pack entry.

Fixes #44886
Fixes #42145
@akoeplinger akoeplinger linked a pull request Nov 15, 2024 that will close this issue
Open
akoeplinger added a commit that referenced this issue Nov 15, 2024
@akoeplinger
Fix updating KnownWebAssemblySdkPack when creating test layout
1b67eef 
We missed adding KnownWebAssemblySdkPack into OverrideAndCreateBundledNETCoreAppPackageVersion so it was pointing to an older version in the BundledVersion.props in the test layout.

Fix that and add some checks so we don't miss this again the next time we add a Known*Pack entry.

Fixes #44886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akoeplinger akoeplinger

Labels
untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix updating KnownWebAssemblySdkPack when creating test layout dotnet/sdk
2 participants
@akoeplinger @ViktorHofer