Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for day and week units in durations. #47

Open
jmalloc opened this issue Mar 4, 2023 · 0 comments
Open

Add support for day and week units in durations. #47

jmalloc opened this issue Mar 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jmalloc
Copy link
Member

jmalloc commented Mar 4, 2023

These are not supported by Go durations as they are technically not fixed-length units of times when accounting for leap-seconds and leap-years, etc. For the purposes of this library we can define one day as exactly 24 hours, and one week as exactly 7 days.

The markdown documentation should contain a <details> section explaining this.
@jmalloc jmalloc added the enhancement New feature or request label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmalloc