Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion: Adapt native standard #1630

Open
mfranzke opened this issue Oct 1, 2023 · 1 comment · Fixed by #1642 · May be fixed by #3218
Open

Accordion: Adapt native standard #1630

mfranzke opened this issue Oct 1, 2023 · 1 comment · Fixed by #1642 · May be fixed by #3218
Assignees
@mfranzke
Labels
🍄🆙improvement New feature or request 😍nice to have Nice to have things

Comments

@mfranzke
Copy link
Member

mfranzke commented Oct 1, 2023 •
edited
Loading

Adapt new native standard of using the name-attribute to controled grouped details/summary components.

https://chromestatus.com/feature/6710427028815872

Expected browser support:
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Oct 1, 2023
@mfranzke mfranzke mentioned this issue Oct 4, 2023
Merged
5 tasks
@mfranzke mfranzke linked a pull request Oct 4, 2023 that will close this issue
feat(accordion): added new name attribute #1642
Merged
5 tasks
@nmerget nmerget added 🍄🆙improvement New feature or request and removed improvement labels Nov 17, 2023
@mfranzke mfranzke reopened this Nov 29, 2023
@mfranzke
Copy link
Member Author

mfranzke commented Nov 29, 2023 •
edited
Loading

Adding the name-attribute to the accordion-items has only been part of the relevant changes – additionally the accordion component itself would need to generate and insert a unique name-attributes-value for all of its child-elements.

@mfranzke mfranzke self-assigned this Nov 30, 2023
@nmerget nmerget added the 😍nice to have Nice to have things label Dec 4, 2023
@mfranzke mfranzke modified the milestones: Open Beta Release, Guidelines 3.0 RC Mar 18, 2024
@mfranzke mfranzke mentioned this issue Aug 6, 2024
Closed
@mfranzke mfranzke linked a pull request Sep 22, 2024 that will close this issue
Draft
5 tasks
@mfranzke mfranzke linked a pull request Sep 22, 2024 that will close this issue
refactor(accordion): adapt native standard for behaviour #3218
Draft
5 tasks
@mfranzke mfranzke removed this from the Guidelines 3.0 RC milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfranzke mfranzke

Labels
🍄🆙improvement New feature or request 😍nice to have Nice to have things
Projects
None yet
Milestone
No milestone
2 participants
@mfranzke @nmerget