language/deferred/redirecting_factory_test is flaky flaky

[askeksa]

There are new test failures on [analysis_server] Change default leading/trailing behaviour for replaceSourceIndent...Revert "Bump version to 3.3.".

The test

language/deferred/redirecting_factory_test RuntimeError (expected Pass)

is failing on configuration

vm-aot-win-debug-x64c

[dcharkes]

Log of today:

--- Command "vm_compile_to_kernel" (took 01.000412s):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & C:\b\s\w\ir\pkg\vm\tool\gen_kernel.bat --aot --platform=out/DebugX64/vm_platform_strong.dill -o C:\b\s\w\ir\out\DebugX64\generated_compilations\vm-aot-win-debug-x64\tests_language_deferred_redirecting_factory_test\out.dill C:\b\s\w\ir\tests\language\deferred\redirecting_factory_test.dart -Dtest_runner.configuration=vm-aot-win-debug-x64 --packages=C:\b\s\w\ir\.dart_tool\package_config.json -Ddart.vm.product=false --sound-null-safety

exit code:
0

--- Command "precompiler" (took 12.000060s):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & out\DebugX64\gen_snapshot --snapshot-kind=app-aot-elf --elf=C:/b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-win-debug-x64/tests_language_deferred_redirecting_factory_test/out.aotsnapshot --loading-unit-manifest=C:/b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-win-debug-x64/tests_language_deferred_redirecting_factory_test/ignored.json --sound-null-safety -Dtest_runner.configuration=vm-aot-win-debug-x64 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:\b\s\w\ir\out\DebugX64\generated_compilations\vm-aot-win-debug-x64\tests_language_deferred_redirecting_factory_test\out.dill

exit code:
0

--- Command "remove_kernel_file" (took 52ms):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & cmd.exe /c del C:\b\s\w\ir\out\DebugX64\generated_compilations\vm-aot-win-debug-x64\tests_language_deferred_redirecting_factory_test\out.dill

exit code:
0

--- Command "vm" (took 291ms):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & set TEST_COMPILATION_DIR=C:/b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-win-debug-x64/tests_language_deferred_redirecting_factory_test & out\DebugX64\dart_precompiled_runtime.exe --sound-null-safety -Dtest_runner.configuration=vm-aot-win-debug-x64 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:/b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-win-debug-x64/tests_language_deferred_redirecting_factory_test/out.aotsnapshot

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Unhandled exception:
Expect.throws fails: Did not throw
#0      Expect._fail (package:expect/expect.dart:881)
#1      Expect.throws (package:expect/expect.dart:766)
#2      test1 (file:///C:/b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:18)
#3      test (file:///C:/b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:42)
#4      main (file:///C:/b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:49)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184)

--- Re-run this test:
python3 tools/test.py -n vm-aot-win-debug-x64 language/deferred/redirecting_factory_test

https://dart-ci.appspot.com/log/vm-aot-win-debug-x64/vm-aot-win-debug-x64/127/language/deferred/redirecting_factory_test

Which is the same error is it was already flaking with:

https://dart-ci.appspot.com/log/vm-aot-win-debug-x64/vm-aot-win-debug-x64/120/language/deferred/redirecting_factory_test

[alexmarkov]

Flipped from flaky to RTE once again: https://dart-ci.appspot.com/log/vm-aot-win-debug-x64/vm-aot-win-debug-x64/147/language/deferred/redirecting_factory_test

[dcharkes]

https://dart-ci.appspot.com/log/vm-aot-win-debug-x64c/vm-aot-win-debug-x64c/464/language/deferred/redirecting_factory_test

[aam]

https://dart-ci.appspot.com/log/vm-aot-linux-debug-simriscv64/vm-aot-linux-debug-simriscv64/472/language/deferred/redirecting_factory_test

--- Command "vm_compile_to_kernel" (took 01.000608s):
DART_CONFIGURATION=DebugSIMRISCV64 /b/s/w/ir/pkg/vm/tool/gen_kernel --aot --platform=out/DebugSIMRISCV64/vm_platform_strong.dill -o /b/s/w/ir/out/DebugSIMRISCV64/generated_compilations/vm-aot-linux-debug-simriscv64/tests_language_deferred_redirecting_factory_test/out.dill /b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart -Dtest_runner.configuration=vm-aot-linux-debug-simriscv64 --packages=/b/s/w/ir/.dart_tool/package_config.json -Ddart.vm.product=false --sound-null-safety

exit code:
0

--- Command "precompiler" (took 07.000307s):
DART_CONFIGURATION=DebugSIMRISCV64 out/DebugSIMRISCV64/gen_snapshot --snapshot-kind=app-aot-elf --elf=/b/s/w/ir/out/DebugSIMRISCV64/generated_compilations/vm-aot-linux-debug-simriscv64/tests_language_deferred_redirecting_factory_test/out.aotsnapshot --loading-unit-manifest=/b/s/w/ir/out/DebugSIMRISCV64/generated_compilations/vm-aot-linux-debug-simriscv64/tests_language_deferred_redirecting_factory_test/ignored.json --sound-null-safety -Dtest_runner.configuration=vm-aot-linux-debug-simriscv64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/out/DebugSIMRISCV64/generated_compilations/vm-aot-linux-debug-simriscv64/tests_language_deferred_redirecting_factory_test/out.dill

exit code:
0

--- Command "remove_kernel_file" (took 15ms):
DART_CONFIGURATION=DebugSIMRISCV64 rm /b/s/w/ir/out/DebugSIMRISCV64/generated_compilations/vm-aot-linux-debug-simriscv64/tests_language_deferred_redirecting_factory_test/out.dill

exit code:
0

--- Command "vm" (took 59ms):
DART_CONFIGURATION=DebugSIMRISCV64 TEST_COMPILATION_DIR=/b/s/w/ir/out/DebugSIMRISCV64/generated_compilations/vm-aot-linux-debug-simriscv64/tests_language_deferred_redirecting_factory_test out/DebugSIMRISCV64/dart_precompiled_runtime --sound-null-safety -Dtest_runner.configuration=vm-aot-linux-debug-simriscv64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/out/DebugSIMRISCV64/generated_compilations/vm-aot-linux-debug-simriscv64/tests_language_deferred_redirecting_factory_test/out.aotsnapshot

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Unhandled exception:
Expect.throws fails: Did not throw
#0      Expect._fail (package:expect/expect.dart:881)
#1      Expect.throws (package:expect/expect.dart:766)
#2      test1 (file:///b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:18)
#3      test (file:///b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:42)
#4      main (file:///b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:49)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184)

--- Re-run this test:
python3 tools/test.py -n vm-aot-linux-debug-simriscv64 language/deferred/redirecting_factory_test

[aam]

another failure https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-aot-win-debug-x64c/583/overview

[alexmarkov]

language/deferred/redirecting_factory_test turned flaky -> RuntimeError on vm-aot-win-debug-x64:

Unhandled exception:
Expect.throws fails: Did not throw
#0      Expect._fail (package:expect/expect.dart:880)
#1      Expect.throws (package:expect/expect.dart:765)
#2      test1 (file:///C:/b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:18)
#3      test (file:///C:/b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:42)
#4      main (file:///C:/b/s/w/ir/tests/language/deferred/redirecting_factory_test.dart:49)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297)
#6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184)

Log: https://dart-ci.appspot.com/log/vm-aot-win-debug-x64/vm-aot-win-debug-x64/288/language/deferred/redirecting_factory_test

[derekxu16]

language/deferred/redirecting_factory_test went has now gone from flaky -> RuntimeError on vm-aot-win-debug-x64c

https://dart-ci.appspot.com/log/vm-aot-win-debug-x64c/vm-aot-win-debug-x64c/660/language/deferred/redirecting_factory_test

Also, maybe this is related to #59905?