Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 12.3.2 requires changes to TS dangerfiles #1457

Closed
cjpearson opened this issue Jun 19, 2024 · 3 comments
Closed

[BUG] 12.3.2 requires changes to TS dangerfiles #1457

cjpearson opened this issue Jun 19, 2024 · 3 comments
Labels

Comments

@cjpearson
Copy link

Describe the bug

When updating to 12.3.2 the danger job fails with the error SyntaxError: Cannot use import statement outside a module. Renaming the file to .mts does not fix the issue.

To Reproduce
Steps to reproduce the behavior:

  1. Create a dangerfile.ts
  2. Use the import { x, y, z } from './scripts/utils' syntax in the file
  3. Upgrade to 12.3.2

Expected behavior

12.6.2 should continue to work with existing dangerfiles.

Your Environment

software version
danger.js 12.3.2
node 20.13.1
npm yarnv1
Operating System alpine linux 3.18
@cjpearson cjpearson added the bug label Jun 19, 2024
@matthewh
Copy link
Contributor

Fixed by #1456

@orta
Copy link
Member

orta commented Jun 20, 2024

Deploy of this fix has just started

@orta orta closed this as completed Jun 20, 2024
@cjpearson
Copy link
Author

12.3.3 works. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants